Talk:Print Functions

From OSDev.wiki
Revision as of 08:54, 23 February 2012 by Solar (talk | contribs) (→‎Bad Style...: Typo.)
Jump to navigation Jump to search

Bad Style...

Apparently, you haven't really understood the point of my criticism over at Printing to Screen. Putting it in a separate page doesn't help. I am sorry for being so blunt, but the quality of your source simply does not satisfy as tutorial / example code. It's undercommented. It has lots of unwieldly constructs (char null = '\0'???). Functions named almost like standard ones that aren't (Puts() and the lack of a newline). Global, externally visible variables and goto? I mean, really? Calling undefined functions (disable() / enable()). I'd probably find more if I cared to look further. That's lots of red ink for 100-something lines of code, and certainly too much for this to reside in our Wiki for others to copy & paste, IMNSHO. -- Solar 02:54, 23 February 2012 (CST)