User talk:Bellezzasolo: Difference between revisions
Content deleted Content added
Re: Recent activity |
|||
(8 intermediate revisions by 4 users not shown) | |||
Line 3:
Welcome to my talk page. My home page is here:
[[User:bellezzasolo]]
Any comments on my style are greatly appreciated, both positive and negative.<br />
If you wish to see my old discussions, go here: [[User:Bellezzasolo/Old_talk]]
== Recent activity ==
Line 62 ⟶ 27:
- [[User:Combuster|Combuster]] 13:55, 22 February 2012 (CST)
== Quality and appropriateness of code ==
Apparently, you haven't really understood the point of my criticism over at [[Printing to Screen]]. Putting it in a separate page doesn't help. I am sorry for being so blunt, but the quality of your "print" source simply does not satisfy as tutorial / example code.
It's undercommented. It has lots of unwieldly constructs (<tt>char null = '\0'</tt>???), functions named ''almost'' like standard ones that aren't (<tt>Puts()</tt> and the lack of a newline), it is calling undefined functions (<tt>disable()</tt> / <tt>enable()</tt>), it's using global externally visible variables - and '''goto?''' I mean, really? I'd probably find more if I cared to look further. That's lots of red ink for 100-something lines of code, and certainly too much for this to reside in our Wiki for others to copy & paste, IMNSHO.
Plus, the overall gist of this Wiki (and the forum) is to '''not''' provide ready-made solutions to copy & paste, but to give the information necessary to do it ''yourself''. For example, the information that 0xb8000 is the beginning of video memory is eligible. The information that the first byte is the ASCII code and the second byte is the color is eligible. The information which value in the color byte corresponds to which color is eligible. Links to existing implementations are eligible. Posting code for <tt>putc()</tt>, <tt>puts()</tt> and <tt>printf()</tt> is ''not'' eligible. -- [[User:Solar|Solar]] 07:02, 23 February 2012 (CST)
== AML ==
Hi, please could you clarify your request for more information on [[AML]] on the [[Wish List]] talk page. Thanks. [[User:Jnc100|John]] 10:27, 5 July 2012 (CDT)
== GOTO ==
Regarding your comments about the use of goto. I am a kernel and hypervisor developer by profession (after doing a hoby OS for longer than I care to admit), and there are many cases where goto is simply the correct solution to a problem. A classic example is for functions which take a spinlock, from which you might otherwise wish to return early. [[User:Andyhhp|Andyhhp]] 16:51, 7 August 2012 (CDT)
I agree entirely. One example is my putc() function. I have scrolling code, and before that I write the character to video memory. I use a goto in vertical tabs (and others) to avoid writing the character.--[[User:Bellezzasolo|Bellezzasolo]] 14:41, 10 August 2012 (CDT)
I can think of correct, readable solutions for both scenarios so I don't think they are good examples. In fact, I find the latter to be a very bad one. The use of <tt>goto</tt> is not bad as long as it doesn't hinder readability, or the code that uses it is produced automatically and not meant to be read by humans (e.g., the output of parser generators). The use of <tt>goto</tt> is ''recommended'' in cases where using anything else would decrease readability (e.g., jumping out of a nested loop, error handling in the absence of exception handling, etc.). --[[User:Love4boobies|Love4boobies]] 10:21, 11 August 2012 (CDT)
==See also==
===Me===
*[[User:Bellezzasolo]]
*[[User:Bellezzasolo/Old talk]]
===Related articles===
*[[SSE]]
|